Skip to content

Conversation

@ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Aug 11, 2025

What problems does this PR address?

Some tests are skipped because diffpy.srreal is unavailable, but the messages said it is because diffpy.structure is unavailable.

@ycexiao ycexiao marked this pull request as ready for review August 11, 2025 22:33
@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.60%. Comparing base (09a8e1c) to head (4531343).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_pdf.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   66.60%   66.60%           
=======================================
  Files          25       25           
  Lines        3171     3171           
=======================================
  Hits         2112     2112           
  Misses       1059     1059           
Files with missing lines Coverage Δ
tests/test_pdf.py 43.29% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit d762f9a into diffpy:main Aug 11, 2025
4 of 5 checks passed
@ycexiao ycexiao mentioned this pull request Aug 11, 2025
18 tasks
@ycexiao ycexiao deleted the correct-test-skip-message branch August 12, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants