Skip to content

tests: correct mesages for skipping tests involving diffpy.srreal #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

tests: correct mesages for skipping tests involving diffpy.srreal #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions news/correct-test-skip-message.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* No news added: Correct messages for skipping tests involving diffpy.srreal.

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* <news item>

**Security:**

* <news item>
8 changes: 4 additions & 4 deletions tests/test_pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def test_setQmax(diffpy_structure_available, diffpy_srreal_available):
from diffpy.structure import Structure

if not diffpy_srreal_available:
pytest.skip("diffpy.structure package not available")
pytest.skip("diffpy.srreal package not available")

pc = PDFContribution("pdf")
pc.setQmax(21)
Expand All @@ -240,7 +240,7 @@ def test_getQmax(diffpy_structure_available, diffpy_srreal_available):
from diffpy.structure import Structure

if not diffpy_srreal_available:
pytest.skip("diffpy.structure package not available")
pytest.skip("diffpy.srreal package not available")

# cover all code branches in PDFContribution._getMetaValue
# (1) contribution metadata
Expand Down Expand Up @@ -269,7 +269,7 @@ def test_savetxt(
from diffpy.structure import Structure

if not diffpy_srreal_available:
pytest.skip("diffpy.structure package not available")
pytest.skip("diffpy.srreal package not available")

pc = PDFContribution("pdf")
pc.loadData(datafile("si-q27r60-xray.gr"))
Expand All @@ -295,7 +295,7 @@ def test_pickling(
from diffpy.structure import loadStructure

if not diffpy_srreal_available:
pytest.skip("diffpy.structure package not available")
pytest.skip("diffpy.srreal package not available")

pc = PDFContribution("pdf")
pc.loadData(datafile("ni-q27r100-neutron.gr"))
Expand Down
Loading