chore: resolve flake8 in datacontainer, imageplot, and live.py #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmx27
reviewed
Sep 26, 2025
src/diffpy/srxplanargui/imageplot.py
Outdated
| "srxconfig", | ||
| desc="Comparing to the average intensity at similar diffraction angle, \npixels with intensity larger than avg_int*high will be masked", | ||
| desc="Comparing to the average intensity at similar diffraction angle," | ||
| + "\npixels with intensity larger than" |
src/diffpy/srxplanargui/imageplot.py
Outdated
| "srxconfig", | ||
| desc="Comparing to the average intensity at similar diffraction angle, \npixels with intensity less than avg_int*low will be masked", | ||
| desc="Comparing to the average intensity at similar diffraction angle," | ||
| + "\npixels with intensity less than avg_int*low will be masked", |
src/diffpy/srxplanargui/imageplot.py
Outdated
| def createPlot(self): | ||
| # image = np.log(self.srx.loadimage.loadImage(self.imagefile)) | ||
| # image = np.log(self.srx.loadimage. | ||
| # loadImage(self.imagefile)) |
Collaborator
There was a problem hiding this comment.
I know that you probably did this because the line was too long, but is it possible to find some other way of doing this? It feels kind of awkward to split up a function call like this. If not, you can probably keep this.
Contributor
Author
There was a problem hiding this comment.
Changed the format, see the new commit
src/diffpy/srxplanargui/imageplot.py
Outdated
| hinttext = Str( | ||
| "Zoom: <z>; Reset: <Esc>; Pan: <drag/drop>; Toggle XY coordinates: <P>" | ||
| "Zoom: <z>; Reset: <Esc>;" | ||
| "Pan: <drag/drop>; Toggle XY coordinates: <P>" |
stevenhua0320
changed the title
Contributor
Author
|
@zmx27 Ready for another review |
Contributor
Author
|
@sbillinge Ready for review |
Contributor
|
As a general matter, I think it is better to break strings without introducting the but instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zmx27 Ready for review same operation in #9
Fix module not used (E402) & cond comparison legacy issue (E711)