fix E402 E711 in datacontainer, imageplot, and live.py #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhua0320
commented
Sep 23, 2025
| Enum, | ||
| Event, | ||
| File, | ||
| Float, |
Contributor
Author
There was a problem hiding this comment.
Delete unused imports
dpx/srxplanargui/imageplot.py
Outdated
| "srxconfig", | ||
| desc="Mask the pixels too bright or too dark compared to the average intensity at the similar diffraction angle", | ||
| desc="Mask the pixels too bright or too dark compared to" | ||
| + "the average intensity at the similar diffraction angle", |
There was a problem hiding this comment.
Similar thing with the extra white space (+ " the...)
dpx/srxplanargui/imageplot.py
Outdated
| self.plot.title = "Click: add a vertex; <Ctrl>+Click: remove a vertex; \n <Enter>: finish the selection" | ||
| self.plot.title = ("Click: add a vertex;" | ||
| + "<Ctrl>+Click: remove a vertex;" | ||
| + "\n <Enter>: finish the selection") |
There was a problem hiding this comment.
If its wrapped in parenths you might not need +, double check this though.
Contributor
Author
|
@cadenmyers13 Have changed for the lavel and plot.title str, ready for review |
|
@sbillinge ready for review |
Contributor
|
same as #8 , this seems to be from the wrong base. Please can you close this and redo it? |
Contributor
Author
|
Close #9 for wrong base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cadenmyers13 Ready for review
Fix module not used (E402) & cond comparison legacy issue (E711)