fix: maintain valid state through the algorithm - #210
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 77.50% 87.32% +9.82%
==========================================
Files 3 3
Lines 40 71 +31
==========================================
+ Hits 31 62 +31
Misses 9 9
🚀 New features to boost your workflow:
|
sbillinge
left a comment
There was a problem hiding this comment.
This probably could use a test for the thing that broke that allowed you to find it in the first place, if you can engineer that. It would be a test that failed with the old code but passes with your current code fix.
Okay, they've been added for both the cubic root solver and the component update loop. |
|
Brilliant! Thanks so much. |
Previously the loose usage of "self.components_" was causing candidate components to be mixed with stored ones during a component update. This fix better matches MATLAB behavior and improves recovery, especially with a broader range of datasets that I previously hadn't tested with.