Skip to content

Sync objcryst upstream and add standalone unit-test workflow - #31

Merged
sbillinge merged 19 commits into
mainfrom
update-objcryst-upstream-sync
Aug 8, 2026
Merged

Sync objcryst upstream and add standalone unit-test workflow#31
sbillinge merged 19 commits into
mainfrom
update-objcryst-upstream-sync

Conversation

@vincefn

@vincefn vincefn commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • update the objcryst submodule to the latest upstream commit
  • add a standalone test/ harness that builds and runs upstream ObjCryst unit tests against libobjcryst
  • add a GitHub Actions workflow to build libobjcryst and run the standalone tests on pull requests
  • move the upstream sync notes into the 2026.2 draft changelog entry and bump the fallback version

Notes

  • the standalone harness currently skips the powder ground-truth regression cases that differ under libobjcryst's double-precision build
  • generated test/bin/ and test/obj/ artifacts are gitignored

vincefn and others added 8 commits August 6, 2026 14:49
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
vincefn and others added 10 commits August 6, 2026 15:17
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SCons builds to build/fast-{machine}/ by default.
Ubuntu x64: build/fast-x86_64/libObjCryst.so
macOS arm64: build/fast-arm64/libObjCryst.dylib

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@vincefn
vincefn marked this pull request as ready for review August 7, 2026 10:04
@vincefn

vincefn commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

@sbillinge @stevenhua0320 - this is ready for review. In addition to the upstream update, there is now a CI, which runs in double precision accuracy.

You can squash & merge if that's fine for you. After the merge, you need to tag the HEAD as v2026.2 so the build works (the CI ignores FALLBACK_VERSION).

@sbillinge

Copy link
Copy Markdown
Contributor

Thanks @vincefn this is great. Wow, that was a lot of work to get that going! For pyobjcryst if you remember we moved from v2025.1 pattern for the release tag to 2025.1.0 pattern so it respected the date.version pattern you were using but also allowed all our automated release workflow machinery to work. I think this is not needed here per se because the release workflow is a bit different perhaps, but is there a conversation to be had about synchronizing that and using 2026.2.0 instead of v2026.2? I am ok either way if it doesn't break our automated workflow downstream.

@vincefn

vincefn commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

2026.2.0 is fine for me as well - I guess libobjcryst also needs an AGENTS.md file so I don't forget.

If you change this also change the fallback version.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@vincefn

vincefn commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

I updated the version to 2026.2.0

@sbillinge sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@sbillinge
sbillinge merged commit 2e5fd3d into main Aug 8, 2026
2 checks passed
@vincefn
vincefn deleted the update-objcryst-upstream-sync branch August 8, 2026 05:32
@vincefn vincefn mentioned this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants