fix: clamp clip drag to timeline start (0s) - #59
Open
PriyeshPandey2000 wants to merge 1 commit into
Open
Conversation
applyClipDrag() applied the raw pointer delta to a clip's start position with no lower bound, so dragging past the 0s mark produced negative start times (visible as e.g. -00:02 in the timecode). The sibling trim path already bounded its edge via trimBounds(); the move/drag path was missing the equivalent floor. Clamp the computed start to 0 to match.
|
@PriyeshPandey2000 is attempting to deploy a commit to the Diffusion Studio Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
applyClipDrag()(apps/web/src/engine/timeline/drag.ts) computed a clip's new start position from the raw pointer delta with no lower bound, then passed it straight tomoveEntityTo(). Dragging a clip past the 0s mark produced a negative start (e.g.-00:02). The sibling trim path already clamps its edge viatrimBounds(); the move/drag path was missing the equivalent floor.Fix
Clamp the computed start to
Math.max(0, ...)inapplyClipDrag(), matching the trim path's bound.Fixes #55