Prove Expr cached flag correctness - #19
Merged
Merged
Conversation
Now that the four Expr cached-flag axioms are theorems, they and their supporting lemmas belong in Verify/Expr.lean; Axioms.lean goes back to holding only genuine axioms and the definitions needed to state them. The block lands before the Literal namespace because Literal.toConstructor_hasLevelParam uses Expr.hasLevelParam'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
digama0
added a commit
that referenced
this pull request
Aug 2, 2026
* prove Expr cached flag correctness * move proved cached-flag lemmas out of Axioms.lean Now that the four Expr cached-flag axioms are theorems, they and their supporting lemmas belong in Verify/Expr.lean; Axioms.lean goes back to holding only genuine axioms and the definitions needed to state them. The block lands before the Literal namespace because Literal.toConstructor_hasLevelParam uses Expr.hasLevelParam'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 2, 2026
kim-em
added a commit
to kim-em/lean4lean
that referenced
this pull request
Aug 3, 2026
Replace the `Level.hasParam_eq` and `Level.hasMVar_eq` axioms with proofs derived from `Level.mkData_eq`, and move them and the structural `hasParam'`/`hasMVar'` definitions out of `Verify/Axioms.lean` into `Verify/Level.lean`, as was done for the Expr cached flags in digama0#19. This also fixes the overflow branch of the `Level.mkData'` model, which was jointly inconsistent with the two flag equalities: see the new docstring. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5K6isCtnCB86J8fRbVTKS
kim-em
added a commit
to kim-em/lean4lean
that referenced
this pull request
Aug 4, 2026
Replace the `Level.hasParam_eq` and `Level.hasMVar_eq` axioms with proofs derived from `Level.mkData_eq`, and move them and the structural `hasParam'`/`hasMVar'` definitions out of `Verify/Axioms.lean` into `Verify/Level.lean`, as was done for the Expr cached flags in digama0#19. This also fixes the overflow branch of the `Level.mkData'` model, which was jointly inconsistent with the two flag equalities: see the new docstring. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5K6isCtnCB86J8fRbVTKS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the four
Exprcached-flag axioms with proofs frommkData_eqandmkAppData_eq.🤖 prepared with Codex