refactor: migrate to the new do elaborator - #33
Merged
Conversation
kim-em
force-pushed
the
agent/migrate-new-do-elaborator
branch
from
August 4, 2026 01:23
17b0a30 to
114fd7f
Compare
Owner
|
leave ShapeLogRel, the change is basically all regression plus this is going to conflict with other branches |
Contributor
Author
digama0
marked this pull request as ready for review
August 4, 2026 03:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #30 and is rebased onto its merged result.
Advances #31. The independent
Experimental/ShapeLogRel.leanmigration remains pinned to the legacy elaborator and is deliberately left for separate work.Summary
backward.do.legacycompatibility pins coveringTypeChecker,EquivManager, andVerify/TypeChecker/ReducedoelaboratorExperimental/ShapeLogRel.leanunchanged to avoid proof-quality regressions and conflicts with ongoing workVerification
lake buildlake build Lean4Lean.Experimentallake exe lean4lean Init.Corelake exe lean4lean --fresh Init.System.IOCoverage note
Removing the
TypeChecker.leanpin changes elaborated terms in code paths whose existing.WFtheorems still containsorry(reduceRecursor,reduceProj,inferProj,tryEtaStructCore, andisDefEqUnitLike). The freshInit.System.IOreplay is therefore part of the safety check, rather than relying only on proof coverage.