fix(css): make sure icon-size follows data-size by default - #5281
Merged
Conversation
🦋 Changeset detectedLatest commit: 0e68e75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Preview deployments for this pull request: storybook - |
mimarz
marked this pull request as ready for review
August 27, 2026 08:45
mimarz
changed the title
icon-size follows data-sizeicon-size follows data-size by default
Barsnes
approved these changes
Aug 27, 2026
eirikbacker
approved these changes
Aug 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in by slack: https://designsystemet.slack.com/archives/C05RK9VEGJ0/p1787818362255529
Since
--ds-icon-sizeis declared on:rootit does not change depending ondata-size(variables on:rootare immutable).Re-declare
--ds-icon-sizeso that it follows new--ds-sizevalues mutated bydata-size.