Skip to content

handle missing parameters in github callback #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
motatoes merged 1 commit into from
Oct 7, 2024
Merged

handle missing parameters in github callback #1753

motatoes merged 1 commit into from
Oct 7, 2024

Conversation

@motatoes
Copy link
Contributor

@motatoes motatoes commented Oct 7, 2024

No description provided.

@delve-auditor
Copy link

delve-auditor bot commented Oct 7, 2024

Security

  • No security or compliance vulnerabilities detected
  • Scanned 1 changed file(s)

Changes Detected

  • [Bug Fix] Add missing parameter checks in GitHub callback [ee/drift/controllers/github.go]

    • Implemented in the GithubAppCallbackPage function
    • Added checks for 'installation_id' and 'code' query parameters
    • Improves error handling by returning 400 Bad Request if parameters are missing

  • [Refactor] Improve variable naming and error logging [ee/drift/controllers/github.go]

    • Updated in the GithubAppCallbackPage function
    • Changed single-value variables to slice variables (installationIds, codes)
    • Added logging for missing parameters

@motatoes motatoes merged commit a53380e into develop Oct 7, 2024
breardon2011 pushed a commit that referenced this pull request Sep 17, 2025
@motatoes
add the missing parameters (#1753)
6251b62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZIJ ZIJ ZIJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@motatoes @ZIJ