Fjerner setting av TLS 1.2 #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💰 Funksjonell beskrivelse av endringen
Det er uheldig at vi setter
ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12i klienten. Dette setter innstillingen også for appen som bruker klientbiblioteket. Dette er uheldig og bør styres av avsender. Dokumentasjon for dette skal lages. Denne fiksen er et resultat av en svært god beskrivelse i #217.En avsender kan uansett bare sette den til noe annet etter at
BaseClienter initialisert for å revertere denne uheldige endringen. Siden vi ikke har fått noen tilbakemeldinger om dette utenom #217, så foreslår jeg at denne fiksen ikke er tilbakevirkende.🏆 Interessante highlights
Ingen.
🤷♀️ Anbefalt fremgangsmåte
Kun 2 linjer endring.
👀 Eksempler og screenshots
...
⚙️ Avhengigheter
Ingen avhengigheter.
🚔 Sikkerhet
Det er backend som sørger for sikkerheten her. Dette er bare for å forhindre at klientbiblioteket mikker med appen som bruker det.