Skip to content

Conversation

@asjafjell
Copy link
Contributor

Introduces the Beta3 XSD and all the happy changes that comes with it.

The important changes are:

  • Sender can be defined in ClientConfiguration and in each DirectJob and PortalJob.
  • Availability is defined by an Activation and AvailableSeconds, not Activation and Expiration as earlier.
  • Polling for changes for DirectJob now requires a token which will be a query-parameter in the ExitUrl the signer was redirected to.

Aleksander Aas Sjåfjell added 7 commits March 9, 2016 14:52
- Modifying AutoSign to receive token
- RejectionUrl instead of CancellationUrl on Portal
- ResponseUrls now has method for getting ResponseUrl, as token has to used as input parameter
- New Xsd files added
- Sender can now be  specified in clientconfig or job, with preference on job.
- Added ClientStub to test BaseClientFunctionality and tests
- Sender can now be  specified in clientconfig or job, with preference on job.
- Added ClientStub to test BaseClientFunctionality and tests
- Availability was never implemented -- now it is
- Statuschange uses ClientConfig sender by default, input otherwise

private StringContent BodyContent()
{
Log.Debug($"Outgoing body: {SerializedBody}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be replaced by configurable request logging :)

@sindrebn
Copy link
Contributor

Looks good. Review the comments and merge at will :)

@asjafjell
Copy link
Contributor Author

Magnificent!

asjafjell added a commit that referenced this pull request Mar 11, 2016
@asjafjell asjafjell merged commit 8c4a8e1 into master Mar 11, 2016
@asjafjell asjafjell deleted the Version3Fixes branch March 31, 2016 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants