Fix and implement missing asset manager methods on BabylonSceneManager - #218
Conversation
This commit implements 'importModelAsset' and 'setTexture' on BabylonSceneManager, ensuring seamless loading and texturing of assets retrieved asynchronously from the IndexedDB. It also updates the 'set_texture_from_asset' generator to use the await keyword, and introduces a new Playwright test verifying the entire integration. Co-authored-by: brettfxio <105930054+brettfxio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements the missing 'importModelAsset' and 'setTexture' methods on BabylonSceneManager to match the existing Blockly block definitions and generators, adds the 'await' keyword to 'set_texture_from_asset' generator to prevent race conditions, and adds a comprehensive Playwright test verifying model loading and texture application directly from IndexedDB.
PR created automatically by Jules for task 13696394119297015271 started by @brettfxio