Skip to content

nfs access point#1865

Merged
DO-rrao merged 5 commits into
digitalocean:mainfrom
v-amanjain-afk:main
Jun 30, 2026
Merged

nfs access point#1865
DO-rrao merged 5 commits into
digitalocean:mainfrom
v-amanjain-afk:main

Conversation

@v-amanjain-afk

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread go.mod Outdated

@rak16 rak16 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, when we list / get access points - it should show multiple VPC's that are attached to the default access point /

Bring in latest changes from digitalocean/doctl while keeping local NFS access point commits.
@DO-rrao

DO-rrao commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Tested this end-to-end (built the binary, ran the commands against prod, and checked the real API responses). Two things came up that are worth a look:

1. The default access point's VPC IDs only show up if you pass --region.
The API doesn't return any VPC info for the default access point, so doctl works around that by looking up the share to fill in the VPC IDs column — but that share lookup needs a region. Since --region is optional on get/list, anyone who leaves it off just sees a blank VPC IDs column for the default AP, which is a little confusing. Could we either make --region required for get/list, or have the default AP return its VPCs directly so the extra lookup isn't needed?

2. Small flag-naming inconsistency in the nfs group.
The new access-point commands use --vpc-id (with a dash), while the existing attach/detach commands use --vpc_id (with an underscore). The dashed version is the usual doctl convention, so it's probably worth switching the older flags over now, before more folks start depending on them.

Neither is a blocker — #1 is the one I'd lean toward fixing before merge.

@DO-rrao DO-rrao merged commit 2f002fb into digitalocean:main Jun 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants