Add : void to ComposerUpdateDrupalCommand::initialize() for Composer compatibility#12
Merged
Merged
Conversation
Composer's BaseCommand::initialize() declares a : void return type. The override omitted it, causing a fatal "declaration must be compatible" error on any composer command in projects that install this plugin under a modern Composer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The command overrides
initialize()without the: voidreturn type that Composer'sBaseCommand::initialize(): voiddeclares. Under a modern Composer this is a fatal "declaration must be compatible" error that aborts any composer command in a project that installs this plugin — currently breaking CI in downstream packages (e.g. digitalpolygon/polymer-drupal).Adds the
: voidreturn type.configure(): voidandexecute(): intwere already correct; this is the only affected method.A
2.0.3-alphaprerelease will be cut frommainonce this merges so downstream^2@devconsumers pick it up.🤖 Generated with Claude Code