Skip to content

Upgrade calamine dependency to 0.36.0#212

Merged
dimastbk merged 1 commit into
dimastbk:masterfrom
dayongxie:upgrade-calamine-0.36.0
Jul 10, 2026
Merged

Upgrade calamine dependency to 0.36.0#212
dimastbk merged 1 commit into
dimastbk:masterfrom
dayongxie:upgrade-calamine-0.36.0

Conversation

@dayongxie

@dayongxie dayongxie commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Upgrade calamine from 0.35.0 to 0.36.0.

Changes:

  • Bump calamine version in Cargo.toml
  • Replace deprecated with
  • Adapt to new return type: instead of
  • Add error mapping for XLS merge cells path (previously returned Option)

Summary by CodeRabbit

  • Bug Fixes
    • Improved worksheet merged-cell retrieval for XLS and XLSX files.
    • Standardized error handling across spreadsheet formats.
  • Maintenance
    • Updated spreadsheet processing support to a newer version, improving compatibility and reliability.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c59fff22-a973-459d-bbc1-fdce6cba4c52

📥 Commits

Reviewing files that changed from the base of the PR and between 1c98022 and 9a57a2c.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • src/types/workbook.rs

📝 Walkthrough

Walkthrough

Calamine is upgraded from 0.35.0 to 0.36.0. Worksheet merge-cell handling for XLS and XLSX now uses merge_cells_by_sheet_name with format-specific error mapping and removes prior XLSX result normalization.

Changes

Calamine merge-cell integration

Layer / File(s) Summary
Calamine upgrade and merge-cell adapter
Cargo.toml, src/types/workbook.rs
The Calamine dependency is updated while retaining the chrono feature, and XLS/XLSX merge-cell lookups use the newer API with mapped results and format-specific errors.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A bunny hops through sheets so bright,
Merged cells now resolve just right.
Calamine gets a newer tune,
Errors wear their formats soon.
“Neat!” squeaks the rabbit, under moon.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: upgrading the calamine dependency to 0.36.0.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dimastbk dimastbk merged commit 79acec2 into dimastbk:master Jul 10, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants