feat: Rerun-compatible CLI args for seamless spawn integration#6
Merged
spomichter merged 1 commit intomainfrom Mar 4, 2026
Merged
feat: Rerun-compatible CLI args for seamless spawn integration#6spomichter merged 1 commit intomainfrom
spomichter merged 1 commit intomainfrom
Conversation
Add clap CLI argument parsing to dimos-viewer so it accepts the same flags that rerun_bindings.spawn() passes to the stock rerun binary: --port (default 9877) --memory-limit (default 75%) --server-memory-limit (default 1GiB) --hide-welcome-screen --expect-data-soon This enables seamless integration with the Rerun SDK: import rerun_bindings rerun_bindings.spawn(executable_name='dimos-viewer', port=9877) No need to fork rerun-sdk or pre-launch the viewer manually. The DimOS bridge can call rerun_bindings.spawn() directly with our binary name as a drop-in replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add clap CLI argument parsing to
dimos-viewerso it accepts the same flags thatrerun_bindings.spawn()passes to the stockrerunbinary.Motivation
Currently the DimOS bridge uses
rr.spawn()which finds and launches thererunbinary with specific CLI args (--port,--memory-limit,--expect-data-soon, etc). To seamlessly swap in our custom viewer, it needs to accept these same args.With this change, the DimOS bridge can do:
No
rerun-sdkfork needed. No manual pre-launch. Same seamless experience as stock Rerun.Changes
clapdependency tocustom_callback/Cargo.tomlArgsstruct with Rerun-compatible CLI flags:--port(default 9877, vs stock Rerun's 9876)--memory-limit(default 75%)--server-memory-limit(default 1GiB)--hide-welcome-screen--expect-data-soon--portarg instead of hardcoded 9877Testing
cargo checkpasses--helpshows all expected flagsrr.spawn():--port=9877 --memory-limit=75% --server-memory-limit=1GiB --expect-data-soonparse correctlyIntegration (DimOS side)
After this merges, the DimOS Rerun bridge (
bridge.py) needs a ~3-line change: