refactor: move dimos-viewer to dedicated dimos/ directory#7
Merged
spomichter merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
Move all DimOS-specific code out of examples/rust/custom_callback/ into
a top-level dimos/ directory. Restore custom_callback to its upstream
Rerun state for easier future merges.
Directory structure:
dimos/
Cargo.toml (dimos-viewer crate)
pyproject.toml (maturin packaging)
dimos_viewer/ (Python wrapper)
tests/ (Python tests)
src/
viewer.rs (main binary with CLI args)
lib.rs
interaction/ (LCM transport module)
Changes:
- Created dimos/ crate with all viewer + LCM code
- Restored examples/rust/custom_callback/ to upstream Rerun state
- Updated CI workflow to reference dimos/ instead of custom_callback
- Added dimos/ to workspace members
- Both crates compile and test independently
Verified:
- cargo check -p dimos-viewer ✓
- cargo test -p dimos-viewer ✓ (13 tests pass)
- cargo check -p custom_callback ✓ (upstream intact)
- dimos-viewer --help shows correct CLI args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move all DimOS-specific code out of
examples/rust/custom_callback/into a top-leveldimos/directory. Restorecustom_callbackto its upstream Rerun state for easier future merges.Motivation
Our viewer code was living in what's supposed to be a Rerun example directory. This makes upstream merges messy and is confusing — our main product shouldn't be in
examples/.New structure
What changed
dimos/examples/rust/custom_callback/Cargo.toml(workspace)dimosto membersPACKAGE_DIR→dimos, cargo commands targetdimos-viewerTesting
cargo check -p dimos-viewer✅cargo test -p dimos-viewer✅ (13 tests pass)cargo check -p custom_callback✅ (upstream intact)dimos-viewer --helpshows correct CLI args ✅