-
Notifications
You must be signed in to change notification settings - Fork 0
fix: default to rerun native viewer #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryChanged the default viewer backend from
The change is functionally correct and aligns with the documentation that describes Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CLI
participant GlobalConfig
participant BlueprintsBuild
participant InitRerunServer
participant RerunViewer
User->>CLI: dimos run unitree-go2
CLI->>GlobalConfig: Load config (viewer_backend)
Note over GlobalConfig: viewer_backend = "rerun-native" (new default)
CLI->>BlueprintsBuild: build(global_config)
BlueprintsBuild->>GlobalConfig: Check viewer_backend.startswith("rerun")
BlueprintsBuild->>InitRerunServer: init_rerun_server(viewer_mode="rerun-native")
Note over InitRerunServer: Uses default parameter value
InitRerunServer->>RerunViewer: rr.spawn(port=9876)
RerunViewer-->>InitRerunServer: Native viewer window launched
InitRerunServer-->>BlueprintsBuild: Return RERUN_GRPC_ADDR
BlueprintsBuild->>GlobalConfig: Update rerun_server_addr
BlueprintsBuild-->>CLI: ModuleCoordinator ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
Additional Comments (2)
|
Co-authored-by: Paul Nechifor <paul@nechifor.net>
|
|
||
| def init_rerun_server(viewer_mode: str = "rerun-web", memory_limit: str = "4GB") -> str: | ||
| def init_rerun_server(viewer_mode: str, memory_limit: str = "4GB") -> str: | ||
| """Initialize Rerun server in the main process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is incorrect below. Still refernces viewer mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile comment: The change is functionally correct and aligns with the documentation that describes rerun-native as offering better performance. However, the docstring comments in rerun_init.py still incorrectly reference rerun-web as the default in two places (lines 23 and 36).
as the title implies