Skip to content

Conversation

@Nabla7
Copy link
Collaborator

@Nabla7 Nabla7 commented Jan 23, 2026

as the title implies

@greptile-apps
Copy link

greptile-apps bot commented Jan 23, 2026

Greptile Overview

Greptile Summary

Changed the default viewer backend from rerun-web to rerun-native across the codebase.

  • Updated GlobalConfig.viewer_backend default value in dimos/core/global_config.py
  • Updated init_rerun_server() default parameter to match in dimos/dashboard/rerun_init.py
  • Native viewer provides better performance with larger maps and higher resolution (per docs/VIEWER_BACKENDS.md)

The change is functionally correct and aligns with the documentation that describes rerun-native as offering better performance. However, the docstring comments in rerun_init.py still incorrectly reference rerun-web as the default in two places (lines 23 and 36).

Confidence Score: 4/5

  • Safe to merge with minor documentation fixes needed
  • The code changes are correct and consistent between global_config.py and rerun_init.py. The change aligns with performance goals documented in VIEWER_BACKENDS.md. However, stale documentation in the docstrings should be updated to reflect the new default.
  • Pay attention to dimos/dashboard/rerun_init.py for documentation updates

Important Files Changed

Filename Overview
dimos/core/global_config.py Changed default viewer_backend from rerun-web to rerun-native
dimos/dashboard/rerun_init.py Updated init_rerun_server default parameter to match new config default, but has stale documentation

Sequence Diagram

sequenceDiagram
    participant User
    participant CLI
    participant GlobalConfig
    participant BlueprintsBuild
    participant InitRerunServer
    participant RerunViewer

    User->>CLI: dimos run unitree-go2
    CLI->>GlobalConfig: Load config (viewer_backend)
    Note over GlobalConfig: viewer_backend = "rerun-native" (new default)
    CLI->>BlueprintsBuild: build(global_config)
    BlueprintsBuild->>GlobalConfig: Check viewer_backend.startswith("rerun")
    BlueprintsBuild->>InitRerunServer: init_rerun_server(viewer_mode="rerun-native")
    Note over InitRerunServer: Uses default parameter value
    InitRerunServer->>RerunViewer: rr.spawn(port=9876)
    RerunViewer-->>InitRerunServer: Native viewer window launched
    InitRerunServer-->>BlueprintsBuild: Return RERUN_GRPC_ADDR
    BlueprintsBuild->>GlobalConfig: Update rerun_server_addr
    BlueprintsBuild-->>CLI: ModuleCoordinator ready
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Jan 23, 2026

Additional Comments (2)

dimos/dashboard/rerun_init.py
documentation says rerun-web is the default, but the code now defaults to rerun-native

    - "rerun-native" (default): Native Rerun viewer (requires display)

dimos/dashboard/rerun_init.py
example code still shows viewer_mode="rerun-web" but should reflect the new default

    server_addr = init_rerun_server(viewer_mode="rerun-native")

paul-nechifor
paul-nechifor previously approved these changes Jan 23, 2026
Co-authored-by: Paul Nechifor <paul@nechifor.net>

def init_rerun_server(viewer_mode: str = "rerun-web", memory_limit: str = "4GB") -> str:
def init_rerun_server(viewer_mode: str, memory_limit: str = "4GB") -> str:
"""Initialize Rerun server in the main process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is incorrect below. Still refernces viewer mode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile comment: The change is functionally correct and aligns with the documentation that describes rerun-native as offering better performance. However, the docstring comments in rerun_init.py still incorrectly reference rerun-web as the default in two places (lines 23 and 36).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants