Skip to content

Conversation

@paul-nechifor
Copy link
Contributor

No description provided.

@greptile-apps
Copy link

greptile-apps bot commented Jan 25, 2026

Greptile Overview

Greptile Summary

Added the @pytest.mark.e2e decorator to the TestControlCoordinatorE2E test class, enabling it to be selectively run using pytest's marker filtering (e.g., pytest -m e2e). Also removed outdated documentation comment showing the pytest command, as this is now handled via the standardized e2e marker defined in pyproject.toml.

  • Added @pytest.mark.e2e decorator to test class (line 33)
  • Removed redundant "Run with" command documentation (lines 19-21)
  • Aligns with existing e2e test pattern used in test_dimos_cli_e2e.py

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • Simple, non-functional change that adds a test marker and removes documentation. No logic changes, no new dependencies, and aligns with established testing conventions in the codebase.
  • No files require special attention

Important Files Changed

Filename Overview
dimos/e2e_tests/test_control_coordinator.py Added @pytest.mark.e2e decorator to test class and removed redundant pytest command comment

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Pytest as Pytest Framework
    participant Test as TestControlCoordinatorE2E
    
    Dev->>Pytest: Run pytest with -m e2e flag
    Pytest->>Test: Check @pytest.mark.e2e decorator
    Note over Pytest,Test: Decorator now present on class
    Pytest->>Test: Execute e2e tests
    Test->>Test: Run test methods
    Test-->>Pytest: Test results
    Pytest-->>Dev: All e2e tests completed
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@leshy leshy merged commit 00295e6 into dev Jan 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants