Skip to content

Add ARM Support#1229

Open
jeff-hykin wants to merge 12 commits intodevfrom
jeff/arm_support
Open

Add ARM Support#1229
jeff-hykin wants to merge 12 commits intodevfrom
jeff/arm_support

Conversation

@jeff-hykin
Copy link
Member

@jeff-hykin jeff-hykin commented Feb 10, 2026

test on an Arm system with:

uv pip install "dimos[unitree] @ git+https://github.com/dimensionalOS/dimos.git@jeff/arm_support"
dimos --replay run unitree-go2

Just uses the stop-gap pypi package published at: https://github.com/jeff-hykin/open3d_jetson
Which is just pre-build wheel files for arm based on the open3d repo

@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR adds ARM (aarch64) Linux support by introducing the open3d-unofficial-arm package alongside the existing open3d dependency. It also includes a temporary workaround in spec.py to fix CI by hardcoding the list of LangChain providers instead of importing them dynamically.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Additional Comments (1)

uv.lock
bitsandbytes markers removed

This lock change removes the sys_platform != 'darwin' and sys_platform != 'win32' markers for bitsandbytes deps, so the lock now claims packaging/torch (and the numpy pins) unconditionally. Since the only wheel listed here is manylinux...aarch64, resolution/install on macOS/Windows is likely to break or at least become inconsistent with the previous intent. If this PR’s goal is ARM support, the platform markers should remain so non-Linux platforms don’t try to resolve/install bitsandbytes from this entry.

@Kaweees
Copy link
Member

Kaweees commented Feb 12, 2026

@greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

{ vals.pkg=pkgs.pcre2; flags={ ldLibraryGroup=pkgs.stdenv.isDarwin; packageConfGroup=pkgs.stdenv.isDarwin; }; }
{ vals.pkg=pkgs.libsysprof-capture; flags.packageConfGroup=true; onlyIf=pkgs.stdenv.isDarwin; }
{ vals.pkg=pkgs.xcbuild; flags={}; }
{ vals.pkg=pkgs.xcbuild; flags={}; onlyIf=pkgs.stdenv.isDarwin; }
Copy link
Member Author

@jeff-hykin jeff-hykin Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change was on dev at some point idk how it got removed but it causes problems because xcbuild is a macos tool

"opencv-python",
"open3d",
"open3d-unofficial-arm; platform_system == 'Linux' and platform_machine == 'aarch64'",
"open3d>=0.18.0; platform_system != 'Linux' or platform_machine != 'aarch64'",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the ONLY change that should be in this PR, everything else is to pass CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants