Merged
Conversation
Contributor
Greptile SummaryThis PR addresses multiple memory leaks in the Open3D integration by implementing proper cleanup mechanisms. The changes include breaking reference cycles in module shutdown, converting function-level caching to instance-level caching for bounding box calculations, and ensuring eager cleanup of tensor-tracked objects before C++ static destructors run. Key changes:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: d98de58 |
5c34d11 to
ee33084
Compare
ee33084 to
cc39cee
Compare
leshy
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Breaking Changes
None.
How to Test
It should end with no Open3D warnings at the end and exit code 0.
Contributor License Agreement