fix: verify macOS multicast route points to loopback#1502
Merged
spomichter merged 1 commit intodevfrom Mar 10, 2026
Merged
Conversation
The multicast configurator checked whether a 224.0.0.0/4 route existed but not which interface it was on. On macOS the route often exists on en0, causing cross-process LCM communication to fail silently.
Contributor
Greptile SummaryThis PR correctly fixes a silent LCM communication failure on macOS where Changes:
The fix is minimal, targeted, and directly solves the stated problem with no breaking changes. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 3c1149d |
Contributor
|
awesomg great catch @SUMMERxYANG |
spomichter
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multicast configurator checks if a
224.0.0.0/4route exists but not which interface it's on. On macOS this route defaults toen0, so the check passes but cross-process LCM communication fails silently.Solution
Verify the route line contains
lo0, not just that it exists.Breaking Changes
None
Contributor License Agreement