fix: misc dev fixes (docs import paths + CameraModule.stop @rpc)#1773
Merged
jeff-hykin merged 24 commits intodevfrom Apr 11, 2026
Merged
fix: misc dev fixes (docs import paths + CameraModule.stop @rpc)#1773jeff-hykin merged 24 commits intodevfrom
jeff-hykin merged 24 commits intodevfrom
Conversation
….py, add typing_extensions dep Address Paul's review comment: fix remaining Self imports that used 'Any as Self' fallback on Python 3.10, and add typing_extensions as an explicit dependency in pyproject.toml.
typer.confirm raises click.Abort when stdin is not a TTY. New dimos/utils/prompt.py provides confirm() that returns the default when not interactive. system_configurator now uses it. Revert: git revert HEAD
dimos/utils/prompt.py provides: - confirm(): returns default if not TTY, else typer.confirm() - sudo_run(): prepends sudo if not root Moved sudo_run from system_configurator/base.py to prompt.py. Updated all importers (base.py, lcm.py, clock_sync.py, tests). Root cause: Ivan's 8edc995 replaced input() with typer.confirm() which raises click.Abort on non-TTY stdin. Revert: git revert HEAD
The test_lcm_autodecoder_pubsub test flaked under full suite load because publish() fired before the handler thread entered the LCM loop. Adding a 50ms sleep after start() in each fixture gives the thread time to be ready.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Non-interactive (no tty) still defaults to True for daemons/CI. Interactive sessions no longer default to yes — pressing Enter without typing y/n now aborts instead of silently applying system changes. Prevents accidental sudo commands from Enter-mashing.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
- Update core/ structure tree to show coordination/ subdir (blueprints.py moved; dimos/core/blueprints.py shim no longer exists). - Fix unclosed code fence after minimal skill example. - Replace nonexistent xarm7-trajectory-sim row with xarm-perception-sim-agent and xarm7-planner-coordinator. - Update spec-pattern source reference to coordination/blueprints.py. - Minor grammar fix in intro. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
leshy
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two small things bundled:
dimos.core.blueprintsimport path after the move todimos.core.coordination.blueprints(the shim still works, but examples should show the canonical path).CameraModule.stop()is a lifecycle hook but wasn't decorated with@rpc, so it wasn't reachable via RPC like the other lifecycle hooks.Solution
AGENTS.md,README.md, and the lidar/temporal-memory/nav READMEs to importautoconnectfromdimos.core.coordination.blueprints.@rpctoCameraModule.stop().Breaking Changes
None.
How to Test
Docs-only changes + a one-line decorator addition — no behavior change beyond making
stop()RPC-callable.Contributor License Agreement