Skip to content

small fixes for release#2019

Merged
paul-nechifor merged 1 commit intodevfrom
paul/fix/release-fixes
May 9, 2026
Merged

small fixes for release#2019
paul-nechifor merged 1 commit intodevfrom
paul/fix/release-fixes

Conversation

@paul-nechifor
Copy link
Copy Markdown
Contributor

@paul-nechifor paul-nechifor commented May 8, 2026

Fix small issues discovered during testing.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 8, 2026

Greptile Summary

This PR introduces a new all meta-extra in pyproject.toml that bundles all individual extras except dds and unitree-dds, replacing the verbose --all-extras --no-extra dds invocation pattern with the simpler uv sync --extra all everywhere. Two small code fixes accompany the tooling change: WebcamConfig is corrected from a @dataclass to a pure Pydantic model, and lidar.py has the stale-timestamp repair simplified.

  • pyproject.toml / uv.lock: A new all extra (agents, base, cpu, cuda, dev, docker, drone, manipulation, misc, perception, psql, sim, unitree, visualization, web) is added and referenced in every install script, CI workflow, and documentation file.
  • dimos/hardware/sensors/camera/webcam.py: @dataclass decorator and dataclasses.field are removed; camera_info now uses pydantic.Field(default_factory=CameraInfo), which is required because WebcamConfig ultimately inherits from pydantic.BaseModel via BaseConfig.
  • dimos/robot/unitree/type/lidar.py: Stale-stamp repair is simplified by removing the per-frame logger.warning; the merge-conflict artifact noted in earlier review has been resolved.

Confidence Score: 5/5

Safe to merge — the changes are a straightforward install-command simplification, a Pydantic correctness fix, and a cleanup of the lidar timestamp repair.

All changes are well-scoped: the new all meta-extra correctly bundles every extra except the two that need special system setup, documentation and CI scripts are updated consistently, and the macOS workflow correctly adds --no-extra all to prevent the meta-extra from dragging in CUDA. The webcam.py fix properly removes the @dataclass decorator that conflicted with pydantic.BaseModel inheritance, and lidar.py is now free of the conflict markers and inconsistent prev_good usage noted in earlier review threads.

No files require special attention.

Important Files Changed

Filename Overview
pyproject.toml Adds the all meta-extra that bundles all installable extras; version bumped to 0.0.12.
dimos/hardware/sensors/camera/webcam.py Correctly replaces @dataclass + dataclasses.field with pydantic.Field so WebcamConfig is a valid Pydantic model.
dimos/robot/unitree/type/lidar.py Removes the per-repair logger.warning; previously raised conflict markers are now resolved and the function is clean.
.github/workflows/ci.yml Switches install step from --all-extras --no-extra dds --no-extra unitree-dds to --extra all.
.github/workflows/macos.yml Adds --no-extra all to prevent the new meta-extra from pulling in CUDA/dds deps on macOS.
uv.lock Regenerated to revision 3 with the new all extra group; some platform-specific CUDA and triton wheel entries were adjusted by the resolver.
scripts/install.sh All uv sync invocations updated to uv sync --extra all.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Developer / CI] -->|Before| B["uv sync --all-extras\n--no-extra dds\n--no-extra unitree-dds"]
    A -->|After| C["uv sync --extra all"]

    C --> D["pyproject.toml\n[all] meta-extra"]
    D --> E["agents, base, cpu, cuda,\ndev, docker, drone, manipulation,\nmisc, perception, psql, sim,\nunitree, visualization, web"]

    D -->|excludes| F["dds\n(requires special setup)"]
    D -->|excludes| G["unitree-dds\n(requires special setup)"]

    subgraph macOS CI
        H["--all-extras\n--no-extra dds\n--no-extra unitree-dds\n--no-extra all\n--no-extra cuda"]
    end

    A -->|macOS workflow| H
    H -->|prevents| I["CUDA packages\n(via 'all' meta-extra)"]
Loading

Reviews (5): Last reviewed commit: "exclude unitree-dds" | Re-trigger Greptile

Comment thread dimos/robot/unitree/type/lidar.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@paul-nechifor paul-nechifor changed the title exclude unitree-dds small fixes for release May 8, 2026
@paul-nechifor paul-nechifor enabled auto-merge (squash) May 8, 2026 17:10
@paul-nechifor paul-nechifor force-pushed the paul/fix/release-fixes branch from 0991b61 to 7f56518 Compare May 8, 2026 17:13
Comment thread dimos/robot/unitree/type/lidar.py Outdated
@paul-nechifor paul-nechifor force-pushed the paul/fix/release-fixes branch 2 times, most recently from de70764 to c2f0461 Compare May 8, 2026 23:08
@paul-nechifor paul-nechifor force-pushed the paul/fix/release-fixes branch from c2f0461 to 6515a5e Compare May 8, 2026 23:45
@paul-nechifor paul-nechifor merged commit 1bd1c2d into dev May 9, 2026
3 of 4 checks passed
@paul-nechifor paul-nechifor deleted the paul/fix/release-fixes branch May 9, 2026 00:11
jeff-hykin pushed a commit that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants