Skip to content

Fixes for some tests#2066

Merged
Dreamsorcerer merged 1 commit into
mainfrom
fix-tests
May 14, 2026
Merged

Fixes for some tests#2066
Dreamsorcerer merged 1 commit into
mainfrom
fix-tests

Conversation

@Dreamsorcerer
Copy link
Copy Markdown
Collaborator

@Dreamsorcerer Dreamsorcerer commented May 12, 2026

A few local test failures for people after #1901. This should resolve those issues.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 12, 2026

Greptile Summary

This PR fixes local test failures by adding pytest.mark.self_hosted to two navigation test modules and the Unity simulation test module, and removes --numprocesses=auto from bin/pytest-slow to prevent parallel-execution conflicts among heavy integration tests. The documentation is updated to match the new pytest-slow invocation.

  • test_cross_wall_planning_far.py and test_cross_wall_planning_simple.py gain the self_hosted mark, excluding them from the default (fast) test suite which lacks the heavy simulation deps they require.
  • test_unity_sim.py gets a module-level pytestmark = pytest.mark.self_hosted, applying the same exclusion to all tests in the file and ensuring they don't run in parallel with the default suite.
  • bin/pytest-slow drops --numprocesses=auto, making the self-hosted/slow suite run serially to avoid resource contention among simulation and navigation tests.

Confidence Score: 5/5

Safe to merge — changes are limited to test markers and a script flag; no production code is touched.

All five changed files deal exclusively with test infrastructure: adding the correct pytest marker to three test modules and dropping a parallelism flag from a helper script. The marker additions are consistent with how the rest of the codebase gates heavy-dep tests, and the serialization of pytest-slow is a straightforward correctness fix for resource contention. Documentation was updated in the same commit. No logic paths or production code are affected.

No files require special attention.

Important Files Changed

Filename Overview
bin/pytest-slow Removes --numprocesses=auto so self-hosted tests run serially; docs updated to match. Correct and intentional change.
dimos/navigation/nav_stack/tests/test_cross_wall_planning_far.py Adds pytest.mark.self_hosted to pytestmark list to exclude this test from the default fast suite that lacks required simulation deps.
dimos/navigation/nav_stack/tests/test_cross_wall_planning_simple.py Identical change to the far-wall planning test: adds pytest.mark.self_hosted to pytestmark.
dimos/simulation/unity/test_unity_sim.py Adds module-level pytestmark = pytest.mark.self_hosted; all tests import from dimos.simulation.unity and dimos.utils.ros1 which require heavy deps, so blanket exclusion from the default suite is appropriate.
docs/development/testing.md Documentation updated in-sync with the pytest-slow script change; description now correctly omits --numprocesses=auto.

Reviews (1): Last reviewed commit: "Fixes for some tests" | Re-trigger Greptile

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...on/nav_stack/tests/test_cross_wall_planning_far.py 0.00% 1 Missing ⚠️
...nav_stack/tests/test_cross_wall_planning_simple.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) May 12, 2026 23:37
@Dreamsorcerer Dreamsorcerer merged commit 6e47ba4 into main May 14, 2026
68 of 85 checks passed
@Dreamsorcerer Dreamsorcerer deleted the fix-tests branch May 14, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants