Add arm to test matrix#2268
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This reverts commit 98df10b.
Greptile SummaryThis PR adds an ARM64 hosted runner (
Confidence Score: 4/5Safe to merge — the ARM runner is properly gated by skip logic, and the existing x86-64 test matrix is unaffected. The CI refactor is clean and the skip mechanism is correctly wired through both the marker path and the fixture path. The only blemish is the platform-check condition being copy-pasted into three files instead of living in one place, but all three copies are identical today so there is no immediate divergence risk. dimos/memory2/conftest.py and dimos/memory2/test_store.py both duplicate the platform skip condition independently of dimos/conftest.py. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CI Matrix Job] --> B{matrix.os}
B -->|ubuntu-latest| C[x86-64 Ubuntu Runner]
B -->|ubuntu-24.04-arm| D[ARM64 Ubuntu Runner]
C --> E{startsWith os ubuntu?}
D --> E
E -->|Yes| F[apt-get install portaudio19-dev]
F --> G[Run pytest]
G --> H{platform.machine == aarch64?}
H -->|Yes| I[skipif_no_sqlite_vec active]
H -->|No| J[All tests run]
I --> K[sqlite-vec tests SKIPPED]
I --> L[Other tests RUN]
J --> M[All tests including sqlite-vec RUN]
Reviews (1): Last reviewed commit: "Include macos" | Re-trigger Greptile |
leshy
left a comment
There was a problem hiding this comment.
actually @Dreamsorcerer "skip if no sqlite vec" is a bit unclear on where this happens,
can we have standardized skip tag per OS? like this would have skip_arm tag? so that we know which OS can cover which functionality
We can, but this needs to be skipped in macos, so I was merging this skip. Can change to adding 2 skip markers if you prefer? |
Fixes #2263.