Skip to content

Conversation

@ThierryBerger
Copy link
Contributor

@ThierryBerger ThierryBerger commented Oct 17, 2024

TODO:

  • This PR doesn´t add the capacity to add interaction group between fluids (yet? It seems to be possible but didn´t look much into it yet.)
  • check benchmarks

Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

}
boundaries[fluid_j].positions[particle_j]
} else {
fluids[fluid_j].positions[particle_j]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a good chance that adding support for groups between two fluids is only a matter of adding a check in this branch too.

@ThierryBerger ThierryBerger merged commit 7e598e8 into dimforge:master Nov 15, 2024
23 checks passed
@Ughuuu
Copy link

Ughuuu commented Nov 16, 2024

So this adds just between fluid/boundary? Still, thanks for this PR.

@ThierryBerger
Copy link
Contributor Author

So this adds just between fluid/boundary? Still, thanks for this PR.

Yes ; fluid / fluid layers will be studied in a follow up PR 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filtering liquids with rapier rigidbodies based on masks/layers

3 participants