Add <!, <=!, >!, >=! - #157
Merged
Merged
Conversation
benikm91
force-pushed
the
add-compare-ops-brodcasts
branch
from
August 25, 2026 07:56
baa02b7 to
b2beccd
Compare
marcelluethi
approved these changes
Aug 26, 2026
marcelluethi
left a comment
marcelluethi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding these operations. It makes sense to have broadcast versions for all these operations. The Syntax is consistent, even if >=! feels a bit like token soup and reminds me of early day sbt 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare operations <, <=, >, and >= lack their broadcast version. This PR adds them.
Add less, greater to mirror add, subtract for + and -
Note:
<!is not supported syntax in Scala, so it was added as'<!'for now. A future solution could be to change the broadcasting syntax to+_!and-_!which would allow<_!and would be inline with where_!. I guess'<!'makes the most sense for now.