fix(kache): stop hardcoding the endpoint and align the pin to 0.13.0 - #44
Merged
Conversation
Two problems in the three reusable workflows that install kache on hosted runners. Both propagate to every consuming repo, which is what makes them worth fixing here rather than downstream. 1. `s3-endpoint: https://s3.tootie.tv` was hardcoded in four places. This repository is public, so that publishes an internal endpoint. Every first-party repo was scrubbed of the same string today (cortex#183, yarr#123, axon#533, labby#377); this is the upstream copy they all call. Now reads ${{ vars.KACHE_S3_ENDPOINT }}, resolved from org variables the same way the per-repo setup-rust-kache action does. 2. `kache-action` was pinned to 0.12.0 while the entire fleet runs 0.13.0 (verified: ci-runner-rust-* report `kache 0.13.0`, and soma/cortex/yarr/ axon all set KACHE_VERSION 0.13.0 on main; v0.13.0 released 2026-08-04). Hosted jobs were therefore writing into the shared s3://kache/rust bucket with a different version than the self-hosted fleet reads it with. The per-repo action carries an explicit warning about this: "The private fleet and hosted CI share the 0.13.0 S3 object layout and daemon protocol. Floating this version could split cache epochs or layouts without an obvious workflow failure." A version mismatch here fails quietly — kache is fail-open, so the symptom is a slow green build or an arbitrary crate failing to compile, not an error that names the cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream counterpart to the fleet-wide kache work done today. Both issues live in the three reusable workflows that install kache on hosted runners, so they propagate to every consuming repo.
1. Hardcoded endpoint in a public repo
s3-endpoint: https://s3.tootie.tvappeared in four places:hosted-kache-canary.yml(×2)hosted-rust-release.ymlhosted-incus-image.ymlThis repository is public. Every first-party repo was scrubbed of that exact string today — cortex#183, yarr#123, axon#533, labby#377 — but they all call these workflows, so the string stayed published here. Now
${{ vars.KACHE_S3_ENDPOINT }}, resolved from org variables the same way each repo's ownsetup-rust-kacheaction does.2. Version drift against the fleet
All four call sites pinned
kache-actionto 0.12.0, while:ci-runner-rust-*binaryKACHE_VERSIONon mainv0.13.0So hosted jobs were writing into the shared
s3://kache/rustbucket using a different version than the self-hosted fleet reads it with. The per-repo action carries an explicit warning about exactly this:Why this class of bug is nasty
kache is fail-open. A version or endpoint mismatch does not produce an error that names the cause — it produces a slow green build, or an arbitrary third-party crate failing to compile with
No such file or directory. Today a 0.12.0/0.13.0 mismatch cost several hours of misdiagnosis across three repos before the version was identified as the cause.Verification
s3.tootie.tvand no0.12.0pins remain anywhere under.github/yaml.safe_load)varsis a valid context in reusable workflows and resolves against the caller's org variables;KACHE_S3_ENDPOINTis already defined org-wide and in use by the per-repo actionsNot changed
kunobi-ninja/kache-actionremains SHA-pinned ata257c055…; only itsversioninput moved. No other workflow references kache.