fix(hicache): support legacy SGLang CP context - #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
xb01 production rolled back the v2.24.3 client after the first Spinfield-managed GLM-5.2 worker crashed in
_resolve_parallel_coordinates: its older SGLangParallelContextexposesattn_cp_size/rankbut noattn_dcp_size/rank.LWS stopped after the first unready worker, limiting impact to one of 17 workers.
Fix
attn_cp_*axis as PCP(1, 0)Verification
ParallelContextregression that lacks both DCP fieldspython3 integration/hicache/tests/test_sg_width_namespace.py: 17/17 passedThe broader unittest discovery also reaches the same 17 passing tests; its unrelated
test_client_statsmodule cannot import locally because this workstation lacks pytest. CI supplies the pinned test environment.