Conversation
Its header said this surface is the only place a safety gate can be relaxed, that "denyDestructive true -> false" and "blockOnInjection true -> false" are categorically different from every other edit, and that they are rendered with a marked row, a red button, and a confirmation requiring explicit acknowledgement. None of it is there. Neither key exists anywhere in the tree — both went with the removed runtime-governance surface and the scanning they switched — and there is no marked row, red button or acknowledgement in this file or anywhere in the frontend: grepping the whole of frontend/src for those keys finds only this comment, and every write on the page goes straight through runWrite. The one `danger: true` in the frontend belongs to deleting a secret. This is the direction that costs something. A reviewer reading the page that edits global governance is told a confirmation guards the dangerous edits, and stops there. internal/ctlapi/adminconfig.go already carries the same correction for the audit trail it used to promise; the GUI half of that story was missed. The header now states what holds: tighten-only merge still makes this the only place a global value can be loosened, ctlapi allows that deliberately, and no edit here is treated as dangerous or confirmed. If such a key returns, the treatment has to be built rather than restored. make ci-full green (exit 0), make gui-frontend-ci green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The information-architecture section said "Tokens, Scope, Sessions and Skills keep routes but stay out of the navigation until they own a task not already expressed by server, profile and client configuration." Config and Auth are hidden too, and for a different reason: they are not waiting for a purpose, they are reached from the page that needs them. The nine navigation destinations are right — they match index.html's data-route links and their three group headings exactly — so the gap is only in the list of what is deliberately absent from it. That is the half a reader consults to answer "what else can this window show", and Config is the GUI's only surface for the global governance keys. Recorded with it: which hidden routes have an in-app link (Auth from Playground, Sessions from onboarding) and which have none at all today. Docs only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly-tidy slice over
cmd/agenthub-gui(Go + frontend) anddocs/modules/gui.md.Verified correct, no change: the nine navigation destinations and their three groups match
index.htmlexactly; the window geometry (1240×800, min 900×620) and the fleet probe'sten-at-a-time concurrency match the code; no dead exported surface on the Go side.
make ci-full(exit 0) andmake gui-frontend-ciboth run, sincemake cicovers neither.