Conversation
…ithdrew Two holes were left after the gate-side cases landed. `profile tool allow` — the third narrowing layer — still had no case that called what it withheld, and no verb that takes access away had one at all: profile_test.go asserts `profile server rm` and `profile rm` against tools/list, and its own comment names the risk, that an rm which does not propagate is a tool the operator believes they took away and did not. The first case builds a fixture where only the profile can be the one narrowing — no `server tool allow` exists and the downstream serves both tools — then calls the withheld sibling and widens with --all. That widen is the first anywhere in the suite for this layer; until now every profile tool fixture only ever narrowed, which cannot be told from a server that never had the tool. The second revokes in two steps and asserts the gate each time: withdraw one server from the profile, then delete the profile under the bound client. The second step is the fail-closed rule at the execute path — a dangling binding resolves to the empty set, and falling back to allow-all there would turn deleting a narrowing profile into granting its client everything the profile was keeping from it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call-side gap closed in #234 left two holes behind:
profile tool allow— one server's tools narrowed for one profile — still had no case that CALLED
what it withheld, and no verb that TAKES access away had one either.
Both matter for the same reason. Every layer intersects and none can widen, so
a narrowing that does not reach the execute path is not a smaller permission,
it is none at all worn as one — and a listing assertion cannot see the
difference. A revocation is where that is worst: it looks correct from every
angle an operator can see while the tool stays callable for anyone who kept
the name.
profile tool allowrefuses the call it withholds, and widening it gives the call backprofile server rmandprofile rmrefuse the calls they withdrew, fail-closed