Conversation
The approval queue was removed rather than left half-wired, because a governance surface that decides nothing still reads as protection (AGENTS.md). 45a668b took the TypeScript, the Go and the e2e suite; it did not take the stylesheet. 126 lines of it were still there: the HITL banner with its role="alertdialog" rationale, the decision countdown and its second-channel bar, the approve button, the decision group, and the greyed "deciding" card state — none with a producer since that commit. That residue is worse than dead code. Its comments are in the present tense and cite docs/modules/gui.md for a banner that document no longer describes, so a reader of the stylesheet concludes this product has a gate that holds a call. It does not, by design. Three orphaned exports go with it, each traceable to the removal that stranded it: confirmBulk and BULK_CONFIRM_THRESHOLD to 45a668b (bulk approve/deny), FILTER_BLOCKS_GLOBAL to 1a32789 (the tool-governance surface, whose "Dismiss all" button it explained), clockTime to 07a3c79 (the retired governance streams). btn-deny stayed and kept its reasoning, rewritten: it began as the deny half of the pair and is now the ordinary destructive action. make gui-frontend-ci and make ci both green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly tidy over the GUI frontend — the one module tonight's rounds had not looked at, and the hottest by recent churn (
style.css49 changes,servers.ts40).The stylesheet residue is the point.
45a668bremoved the human-approval surface from the TypeScript, the Go and the e2e suite, and left the HITL banner, the decision countdown, the approve button and the "deciding" card state in the stylesheet — with comments in the present tense citingdocs/modules/gui.mdfor a banner that document no longer describes..btn-denystayed (7 live callers) and kept its reasoning, rewritten for what it is now.Verified
make gui-frontend-ci(npm ci,tsc --noEmit, production build) as well asmake ci— the frontend is outside the default build, somake cialone would not have caught a broken stylesheet.