Skip to content

tidy-discovery: a package doc that rendered as a code block - #276

Merged
dinstein merged 1 commit into
mainfrom
tidy-discovery
Aug 9, 2026
Merged

tidy-discovery: a package doc that rendered as a code block#276
dinstein merged 1 commit into
mainfrom
tidy-discovery

Conversation

@dinstein

@dinstein dinstein commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Nightly tidy pass, 2026-08-10 00:17 round. Two slices were opened; the first
produced nothing.

internal/ratelimit — quiet, nothing landed. Read end to end (doc,
limiter, admission, config, governance, state). All three passes came up
empty, and the doc's claims check out, including "the production wiring is
internal/gateway/ratelimit.go" and "an assembly is expected to wire Logger
and OnEvent" — the gateway wires Store, Logger and OnEvent. The branch was
discarded rather than filled.

internal/discovery — this PR.

  • Pass C — the package doc's opening sentence was split across three
    blocks with its middle third tab-indented, so go doc rendered it as a
    code block. The stray / 7.2 is residue of a removed section citation,
    the same shape repaired in internal/scope earlier tonight.
  • Pass Citoa's comment said collision suffixes were its only
    user; query.go has three call sites and describe.go one.
  • Pass A / Pass B — nothing cleared the bar.

Verification: make ci green; go doc ./internal/discovery now prints prose.

The opening sentence was split across three comment blocks with its middle
third indented by a tab, so godoc rendered "/ 7.2 — full, grouped and lazy —
plus the lexical ranker, the" as a code block wedged between two prose
fragments. The "/ 7.2" is residue of a section citation that was removed
without the slash, the same shape repaired in internal/scope's package doc.

One paragraph now, and `go doc ./internal/discovery` prints it as prose.

While there: itoa's comment claimed the grouped-mode collision suffix was its
only user. query.go has three call sites and describe.go one, all building
frozen error messages, which is the reason worth recording — those sentences
are assembled by concatenation alone and so stay trivially identical to their
golden files.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dinstein
dinstein merged commit 4a4e66d into main Aug 9, 2026
3 checks passed
@dinstein
dinstein deleted the tidy-discovery branch August 9, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant