Skip to content

tidy-pipeline: a package doc justifying a scan that is gone - #285

Merged
dinstein merged 1 commit into
mainfrom
tidy-pipeline
Aug 9, 2026
Merged

tidy-pipeline: a package doc justifying a scan that is gone#285
dinstein merged 1 commit into
mainfrom
tidy-pipeline

Conversation

@dinstein

@dinstein dinstein commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Nightly tidy pass over internal/pipeline (2026-08-10 04:47 round).

  • Pass C — the package doc said "Success and error branches share
    defend_and_shape (docs/flows.md: a malicious server must not bypass
    scanning by answering with a JSON-RPC error)". There is no scanning.
    Everything else in the tree already records that: shape.go says what
    is left "inspects nothing and decides nothing about a call",
    docs/modules/dataplane.md says the scans and their ordering rules went
    with the governance surface, and ShapeFunc — three paragraphs below,
    in the same file — calls the stage "defend_and_shape, which no longer
    defends, only shapes".

    So the place a reader meets first was the last one still naming a
    defence the code does not have, and naming it as the *reason* both
    branches share a stage. The reason is now the one `architecture.md` §5
    already gives: the counter advances either way, which is what the
    stdio/HTTP gate-count parity assertions compare, while only the success
    branch is shaped because an error carries no payload to bound.
    
  • Pass A / Pass B — nothing cleared the bar. Execute's chain is five
    lines, ScopeAllows and both gates document their failure directions,
    and Counters()' type assertion is nil-safe on the documented
    NewWithGates(_, nil) shape.

CallRequest.InputSchema is unread and says so, with the argument for leaving
it (deleting it should be a decision, not a side effect) — left alone, same
call as session.ClientCaps.ToolsListChanged two rounds ago.

Comment only; the prose docs needed no edit, being right already.
Verification: make ci green.

…hat is gone

The front door said "Success and error branches share defend_and_shape
(docs/flows.md: a malicious server must not bypass scanning by answering with
a JSON-RPC error)". There is no scanning. The injection and leak stages went
with the rest of the runtime governance surface, and everything else already
records that: shape.go says what is left "inspects nothing and decides nothing
about a call", docs/modules/dataplane.md says the scans and their ordering
rules are gone, and ShapeFunc — three paragraphs down in this same file —
calls the stage "defend_and_shape, which no longer defends, only shapes".

So the one place a reader meets first was the one place still naming a defence
the code does not have, and naming it as the REASON both branches share a
stage. The reason is now what architecture.md §5 already states: both branches
advance the counter, which is what the stdio/HTTP gate-count parity assertions
compare, while only the success branch is shaped because an error carries no
payload to bound.

Comment only; the prose docs needed no edit, being right already.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dinstein
dinstein merged commit 345f71d into main Aug 9, 2026
3 checks passed
@dinstein
dinstein deleted the tidy-pipeline branch August 9, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant