tidy-pipeline: a package doc justifying a scan that is gone - #285
Merged
Conversation
…hat is gone The front door said "Success and error branches share defend_and_shape (docs/flows.md: a malicious server must not bypass scanning by answering with a JSON-RPC error)". There is no scanning. The injection and leak stages went with the rest of the runtime governance surface, and everything else already records that: shape.go says what is left "inspects nothing and decides nothing about a call", docs/modules/dataplane.md says the scans and their ordering rules are gone, and ShapeFunc — three paragraphs down in this same file — calls the stage "defend_and_shape, which no longer defends, only shapes". So the one place a reader meets first was the one place still naming a defence the code does not have, and naming it as the REASON both branches share a stage. The reason is now what architecture.md §5 already states: both branches advance the counter, which is what the stdio/HTTP gate-count parity assertions compare, while only the success branch is shaped because an error carries no payload to bound. Comment only; the prose docs needed no edit, being right already. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly tidy pass over
internal/pipeline(2026-08-10 04:47 round).Pass C — the package doc said "Success and error branches share
defend_and_shape(docs/flows.md: a malicious server must not bypassscanning by answering with a JSON-RPC error)". There is no scanning.
Everything else in the tree already records that:
shape.gosays whatis left "inspects nothing and decides nothing about a call",
docs/modules/dataplane.mdsays the scans and their ordering rules wentwith the governance surface, and
ShapeFunc— three paragraphs below,in the same file — calls the stage "defend_and_shape, which no longer
defends, only shapes".
Pass A / Pass B — nothing cleared the bar.
Execute's chain is fivelines,
ScopeAllowsand both gates document their failure directions,and
Counters()' type assertion is nil-safe on the documentedNewWithGates(_, nil)shape.CallRequest.InputSchemais unread and says so, with the argument for leavingit (deleting it should be a decision, not a side effect) — left alone, same
call as
session.ClientCaps.ToolsListChangedtwo rounds ago.Comment only; the prose docs needed no edit, being right already.
Verification:
make cigreen.