Fix release feed-validation gate: read feeds via API (runs on a draft) - #29
Merged
Conversation
…release The auto-update feed-validation gate fetched latest*.yml from the public releases/download/<tag>/ URL. But it runs in `finalize` BEFORE the release is un-drafted, and draft assets 404 at that public URL — so every feed read failed with "feed missing" and the gate blocked the release (v0.2.0-rc.7 stranded as a draft even though the build was correct and DID contain the mac zip). Fetch each feed with `gh release download` instead, which authenticates through the API and can see draft assets. Also check the feed is an attached asset up front. Validated against the real rc.7 draft: mac→zip, win→exe, linux→AppImage all pass. rc.7 was finalized manually after confirming the build was sound; this makes the next release finalize on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-update feed-validation gate added in the mac-updater fix blocked v0.2.0-rc.7 — a false failure.
Bug: the gate
curlslatest*.ymlfromhttps://github.com/OWNER/REPO/releases/download/<tag>/…. But it runs in thefinalizejob before the release is un-drafted, and draft assets 404 at that public URL. Every feed read failed → the gate reported "feed missing" → the release stayed a draft, even though the build was correct and DID contain the new mac.zip.Fix: fetch each feed with
gh release download(authenticated, sees drafts) instead of the public URL, and check the feed is an attached asset first.Verified against the real rc.7 draft:
latest-mac.yml → SpyDE-*-arm64-mac.zip,latest.yml → *.exe,latest-linux.yml → *.AppImageall pass. rc.7 was finalized manually (build confirmed sound); this makes the next release finalize automatically.