Skip to content

Run end-to-end tests only if corresponding files have been modified#10135

Merged
rijkvanzanten merged 1 commit intodirectus:mainfrom
paescuj:limit-e2e-tests-runs
Nov 29, 2021
Merged

Run end-to-end tests only if corresponding files have been modified#10135
rijkvanzanten merged 1 commit intodirectus:mainfrom
paescuj:limit-e2e-tests-runs

Conversation

@paescuj
Copy link
Copy Markdown
Contributor

@paescuj paescuj commented Nov 29, 2021

This ensures that the end-to-end tests are only performed if files have been modified that match the following patterns:

  • api/**/*
  • tests/**/*
  • docker-compose.yml
  • .github/workflows/e2e-tests.yml

@rijkvanzanten rijkvanzanten added this to the v9-next milestone Nov 29, 2021
@rijkvanzanten rijkvanzanten enabled auto-merge (squash) November 29, 2021 14:59
@rijkvanzanten rijkvanzanten merged commit 76a306e into directus:main Nov 29, 2021
@paescuj
Copy link
Copy Markdown
Contributor Author

paescuj commented Nov 29, 2021

FYI @rijkvanzanten: Similar to the e2e tests we could configure other filter rules to run individual jobs only if the changed files match the defined path patterns...
Thanks to the paths_filter option (I'm going to update the description of the PR soon 😄) in the skip-duplicate-actions.

@paescuj paescuj deleted the limit-e2e-tests-runs branch November 29, 2021 15:12
@paescuj
Copy link
Copy Markdown
Contributor Author

paescuj commented Nov 30, 2021

Sorry @rijkvanzanten, one last note on this: You might want to add the "End-to-End Tests / Result" as a required check on pull requests, since a) the tests now run only if appropriate and b) they generally seem to work now.

(If you're interested in the possibilities that arise with the new feature in 'skip-duplicate-actions', I've now updated the description of the pull request...)

@paescuj paescuj restored the limit-e2e-tests-runs branch October 24, 2022 11:46
@paescuj paescuj deleted the limit-e2e-tests-runs branch October 24, 2022 11:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants