Optimize media loading across app#10592
Merged
rijkvanzanten merged 37 commits intomainfrom Jul 20, 2022
Merged
Conversation
rijkvanzanten
changed the title
Member
|
I'm hijacking this PR to achieve the same thing for GIFs, audio, and video! |
licitdev
reviewed
Dec 28, 2021
Co-authored-by: ian <licitdev@gmail.com>
Member
|
Lets use https://videojs.com for video / audio |
3 tasks
It doesn't do authorization headers for mp4/mp3, so it's pointless
rijkvanzanten
approved these changes
Jul 20, 2022
qborisb
pushed a commit
to qdentity/directus
that referenced
this pull request
Jul 22, 2022
* v-image and "lazy load" working * fixed vars * all the other img uses * No longer require access token in url for files * Add lazy loading and size limits * Rename map-component source prop * Fix lint warning * Update app/src/views/public/public-view.vue Co-authored-by: ian <licitdev@gmail.com> * Fix lint * Fix missing file type icon * Fix null imageInfo error * Use video.js for media playback * Fix .js file display * Update package-lock.json * Update package-lock.json * update package.json * Update pnpm-lock.yaml * Remove unrelated addition on VDatePicker * Remove folder abstraction * Use image data based aspect ratio on preview * Base app rate throttle on API rate limit config * Configure app rate limit throttle based on api config * Convert v-image to script[setup] * Convert v-media to script[setup] * Cleanup v-media * Remove unneeded addTokenToUrl usages * Remove video.js It doesn't do authorization headers for mp4/mp3, so it's pointless Co-authored-by: rijkvanzanten <rijkvanzanten@me.com> Co-authored-by: ian <licitdev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11652, fixes #14513
Adds a new v-image wrapper component that augments the browser native
<img>with some Directus magic, most notably: