-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Generate joi merge #13596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate joi merge #13596
Conversation
…rate-joi-merge
…rate-joi-merge
…rate-joi-merge
…rate-joi-merge
…rate-joi-merge
|
@licitdev could you do a review to make sure the behavior is consistent across the original uses of the util? I'm mostly worried about the difference in |
|
@rijkvanzanten Yes, The I'm worried about regressions, particularly because it's used in parsing filters in permissions. Will need some time to investigate deeper. |
|
What kind of tests does this need to be merged? I can whip some up today. |
…rate-joi-merge
…rate-joi-merge
…rate-joi-merge
…rate-joi-merge
…rate-joi-merge
|
This PR also fixes #13119 from the updated |
Description
We have generate-joi/index.ts in the app with a comment that the function should be shared. We also have generate-joi.ts in the shared package. They both (to me) seem to do the same thing but slightly differently.
The benefit of merging them is that operators, updates, and optimizations don't need to be added in both places.
I also updated the
app/jest.config.jsto properly resolve@/imports.NOTE: Neither implementation seems to support _and or _or
Fixes #13595
Fixes #13855
Fixes #13119
Type of Change
Requirements Checklist
If adding a new feature: