Skip to content

Conversation

@br41nslug
Copy link
Member

@br41nslug br41nslug commented Jun 22, 2022

Description

Applying the field conditions was causing an update loop. Whenever any value changed all field definitions were re-evaluated and updated resulting in each and every input in the v-form re-rendering for any value change.

My solutions attempts to split the reactive meta fields updated by conditions and the field definitions to prevent unnecessary re-renders.

Fixes #13237, fixes #13460

Type of Change

  • Bugfix
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

@br41nslug br41nslug marked this pull request as ready for review June 22, 2022 14:31
Copy link
Contributor

@azrikahar azrikahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! Can confirm it'll resolve #13460 as well 🙌

Before

We can see when I hold the 'A' key, the input is seemingly unresponsive until I let go, same thing with 'Backspace'.

chrome_rCVxYommdl.mp4

After

chrome_YsvLBjOK9N.mp4

@br41nslug br41nslug requested a review from licitdev June 22, 2022 15:05
@rijkvanzanten rijkvanzanten added this to the v9-next milestone Jun 22, 2022
@rijkvanzanten rijkvanzanten self-assigned this Jun 22, 2022
@rijkvanzanten rijkvanzanten merged commit c3334e5 into main Jun 22, 2022
@rijkvanzanten rijkvanzanten deleted the issue/13237 branch June 22, 2022 17:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkbox Tree makes admin UI unresponsive, slow Major input delays on text fields in complex documents

4 participants