-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Refactor unnecessary nested app folders #14580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qborisb
pushed a commit
to qborisb/directus
that referenced
this pull request
Jul 28, 2022
* Remove unused nested folders from components * Remove nested folders * Standardize composables output * Fix import inconsistencies * Same trick for directives * Same for routes * Replace reliance root grouped export in favor of explicit imports * Replace reliance on implicit imports * Remove nested folder structure * Consistent use of non-default exports in utils * Remove nested folder structure from private components * Fix test mock * Remove extraneous component registration for valuenull * Fix stores provider * Fix logo sprite
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the app was first created, the decision was made to put every util/composable/component into a folder, with an index.ts file that would reexport the component:
The idea behind this was that it would make the usage of these parts nicer, by allowing any:
However, in practice this is rather pointless. Dev tooling nowadays will autocomplete and resolve imports on your behalf, and this mixed usage turned into a bit of a messy import system, where different components would use different strategies. It also means that you can't properly rely on global searching, as the generic import means that components can import them under a different name. It also complicates testing coverage a bit, as there's a lot of needless imports/exports that need to be re-tested. This PR cleans that up to prepare for easier integration with testing suites coming soon.
Also removing the outdated
readme.mdfiles that were scattered around the nested folders in favor of moving that into the docs