Drop SendGrid email transport support

[florian-strasser]

Based on issue #23217 I removed the nodemailer-sendgrid else if branch

What's changed:

• We are dropping support sendgrid

Potential Risks / Drawbacks

• It's a breaking change that forces users that rely on this to switch to SMTP

Review Notes / Questions

• nodemailer/sendgrid received the last update 6 years ago which should make clear that this absolutely outdated: https://github.com/nodemailer/nodemailer-sendgrid

---

Closes #23217

[changeset-bot]

🦋 Changeset detected

Latest commit: 2c712db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@directus/api	Major
directus	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[florian-strasser]

I would also remove the nodemailer-sendgrid package from api/package.json, but I'm not sure if it is currently used in any other file than api/src/mailer.ts

[florian-strasser]

Not sure how to fix the current errors, probably I should not just remove the line from package.json.

  WARN  There are cyclic workspace dependencies: /home/runner/work/directus/directus/api, /home/runner/work/directus/directus/directus 

ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with api/package.json

[paescuj]

Not sure how to fix the current errors, probably I should not just remove the line from package.json.

  WARN  There are cyclic workspace dependencies: /home/runner/work/directus/directus/api, /home/runner/work/directus/directus/directus 

ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with api/package.json

Heya @McSundae 👋 You need to run pnpm install to update the lockfile after the change to the package.json file.

[paescuj]

We also need to mention this on the "Breaking Changes" page ¹², advising users to switch to SMTP as per #23217 (comment).

Footnotes

1. https://docs.directus.io/releases/breaking-changes.html ↩

2. https://github.com/directus/directus/blob/1a2a085731638bf9dff87267b3efee02d7533c2a/docs/releases/breaking-changes.md ↩

[u12206050]

WHY?!? More importantly why not release this on a minor release, it is a big breaking change to anyone using Sendgrid.

[florian-strasser]

@u12206050 I understand your frustration, but as mentioned in the initial issue the package that was used for this is not maintained since over 6 years, so it is a security issue to keep it inside of directus. We recommend to use smtp to connect with send grid.

The package I'm talking about is:
https://github.com/nodemailer/nodemailer-sendgrid

[u12206050]

@u12206050 I understand your frustration, but as mentioned in the initial issue the package that was used for this is not maintained since over 6 years, so it is a security issue to keep it inside of directus. We recommend to use smtp to connect with send grid.

The package I'm talking about is: https://github.com/nodemailer/nodemailer-sendgrid

Thanks, that I understand, although I still don't understand how this could be released as a patch release, are we too assume from now on that patch releases could also contain breaking changes?

[jogi-k]

Same opinion. Why are you bringing out breaking changes in hotfixes?
Thats completely incompatible with semantic versioning

Not that I would be affected, but it directly caught my attention when looking at the release-notes.

[inovosel]

Have you added any guide/instructions how to get SendGrid working again after you have removed support for SendGrid transport? Or a way how to manually add SendGrid transport support (with me taking all the risks for using outdated component)?

[florian-strasser]

As already mentioned it is recommended to use simply smtp. So you simply go into your config file and change the specific parameters:

https://docs.directus.io/self-hosted/config-options.html#smtp-smtp