Fix sidebar-detail missing fetch data after navigation (#23520)#23553
Merged
paescuj merged 5 commits intodirectus:mainfrom Sep 6, 2024
Merged
Fix sidebar-detail missing fetch data after navigation (#23520)#23553paescuj merged 5 commits intodirectus:mainfrom
paescuj merged 5 commits intodirectus:mainfrom
Conversation
|
- Define & re-use titles - Omit null checks since values are always null when mounted
paescuj
approved these changes
Sep 6, 2024
Contributor
paescuj
left a comment
There was a problem hiding this comment.
Nice fix, thanks @SP12893678 ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
A few sidebar detail expected fetch data after sidebar open.
But when user open the sidebar, navigation to other page and then go back.
It will not show data(no fetch data) in sidebar, but sidebar-detail is open.
What's changed:
Issue Demo:
bandicam.2024-09-03.21-42-05-837.mp4
Fixed Demo:
bandicam.2024-09-03.21-40-11-119.mp4
Potential Risks / Drawbacks
Review Notes / Questions
Fixes #23520