Skip to content

Fix sidebar-detail missing fetch data after navigation (#23520)#23553

Merged
paescuj merged 5 commits intodirectus:mainfrom
SP12893678:fix/#23520-sidebar-missing-fetch-data
Sep 6, 2024
Merged

Fix sidebar-detail missing fetch data after navigation (#23520)#23553
paescuj merged 5 commits intodirectus:mainfrom
SP12893678:fix/#23520-sidebar-missing-fetch-data

Conversation

@SP12893678
Copy link
Contributor

Scope

A few sidebar detail expected fetch data after sidebar open.
But when user open the sidebar, navigation to other page and then go back.
It will not show data(no fetch data) in sidebar, but sidebar-detail is open.

What's changed:

  • Append fetch data in onMounted if sidebar is open.

Issue Demo:

bandicam.2024-09-03.21-42-05-837.mp4

Fixed Demo:

bandicam.2024-09-03.21-40-11-119.mp4

Potential Risks / Drawbacks

  • N/A

Review Notes / Questions

  • N/A

Fixes #23520

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: e848726

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paescuj paescuj self-assigned this Sep 6, 2024
@paescuj paescuj added the Bug label Sep 6, 2024
Copy link
Contributor

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks @SP12893678 ❤️

@paescuj paescuj enabled auto-merge (squash) September 6, 2024 12:17
@paescuj paescuj merged commit e659653 into directus:main Sep 6, 2024
@github-actions github-actions bot added this to the Next Release milestone Sep 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Right sidebar tab content is missing after navigation, only gets rendered after interaction

2 participants