Prevent unnecessary permission API request#24178
Merged
rijkvanzanten merged 2 commits intomainfrom Dec 9, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: db7a662 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rijkvanzanten
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
The
isActionAllowedfunction was designed in a way to prevent unnecessary API requests. That is, if the permissions for a collection are either "none" or "full", there's no need to check the permissions for individual items (/permissions/me/<collection>/<item>endpoint).With the introduction of the policy system, this no longer worked as intended for the "none" permissions case.
Therefore, the function and associated tests have now been adjusted accordingly.