Skip to content

Fix license settings#27448

Merged
robluton merged 7 commits into
licensefrom
hugo/fix-license-settings
May 13, 2026
Merged

Fix license settings#27448
robluton merged 7 commits into
licensefrom
hugo/fix-license-settings

Conversation

@HZooly
Copy link
Copy Markdown
Member

@HZooly HZooly commented May 13, 2026

Scope

What's changed:

  • Add license settings page with plan info, entitlements, add-ons, and deactivation flow
  • Hide add-ons section for non-Team plans (shown only when the server returns available add-ons)
  • Hide "Manage" button and Danger Zone for Core tier (identified by source === null)
  • Fix expiry/renewal date rendering for unlimited licenses (expires_at = -1)
  • Guard MaxCapacityAlert in Collections and Flows views so the wrapper only renders when capacity is actually exceeded
  • Wire collections and flows views to the license guard (entitlement limit modal, entitlement remaining counter)
  • Remove deprecated VBreadcrumb headline slots from Collections and Flows

Potential Risks / Drawbacks

  • Core-tier detection relies on source === null; any future non-Core unlicensed state would also suppress the Manage button and Danger Zone
  • Add-ons visibility is fully backend-driven — if the server ever returns add-ons for a non-Team plan, the section will appear

Tested Scenarios

  • License page renders correctly for Core tier (no Manage button, no Danger Zone, no add-ons section)
  • License page renders correctly for Team tier (Manage button present, Danger Zone present, add-ons section visible when add-ons available)
  • Unlimited license (expires_at = -1) shows no expiry/renewal date
  • Collections and Flows pages show the capacity alert only when at or over the limit

Review Notes / Questions

  • I would like reviewers to verify the source === null heuristic covers all intended Core-tier cases and doesn't accidentally hide controls for other unlicensed states

Checklist

  • Added or updated tests
  • Documentation PR created here or not required
  • OpenAPI package PR created here or not required

Fixes CMS-2329

@HZooly HZooly requested a review from AlexGaillard as a code owner May 13, 2026 17:11
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 13, 2026

CMS-2329

@HZooly HZooly changed the title Hugo/fix license settings Fix license settings May 13, 2026
Comment thread app/src/modules/settings/routes/license/license.vue
Copy link
Copy Markdown
Contributor

@robluton robluton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

@robluton robluton merged commit 02c16f2 into license May 13, 2026
5 checks passed
@robluton robluton deleted the hugo/fix-license-settings branch May 13, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants