fix(android): Add multi-activity awareness to ReactHostImpl.onHostDestroy#161
Merged
joemun merged 1 commit into0.81.4-discordfrom Apr 14, 2026
Merged
Conversation
onHostPause already checks activeActivities and skips pausing when other activities are still active. onHostDestroy lacked this check, so destroying a secondary activity while the primary was still alive would move the shared ReactContext to BEFORE_CREATE. If the primary was never paused, no subsequent onHostResume would fire, leaving the context permanently destroyed and unresponsive to input. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this previous fix: e09d4e8
onHostPausechecksactiveActivitiesand skips pausing when other activities are still active.onHostDestroylacked this check, so destroying a secondary activity while the primary was still alive would move the sharedReactContexttoBEFORE_CREATE:react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.kt
Lines 794 to 797 in e291c1e
react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactLifecycleStateManager.kt
Lines 70 to 90 in e291c1e
If the primary activity was never paused, no subsequent
onHostResumewould fire, leaving the context permanently destroyed and unresponsive to input.