This repository was archived by the owner on Dec 24, 2021. It is now read-only.
Conversation
Member
|
The property needs to be documented in CommandInfo as well. |
Member
|
Oh, and typings, too. :) |
faizal101
added a commit
to faizal101/Commando
that referenced
this pull request
Nov 2, 2018
* Fix error not being overridden with async validators * Add union types to feature list * Change registerDefaultCommands to use eval instead of eval_, and improve docs * Improve more registry docs * Allow specifying specific types to register * Rearrange registration logic and improve docs * Remove useless commands parameter from CommandGroup constructor * Add dank testing of dank argument type functionality * Update typings * Remove unnecessary codeblock markdown * Specify that the guild's name is needed in help * message#member is a getter now. * Add BetterSQLite3 Provider * Fix: Emit distinct event for BetterSQLiteProvider * Resolve vague method naming * Resolves distinct event by using @fires to reference providerReady event * Bump development version * Make getGuildID static in Typings * Update Typings (discordjs#151) Added Client as an alias of CommandoClient Added util and version * Remove duplicate setProvider method (Fix: Gawdl3y review) * Rename BetterSQLite3Provider to SyncSQLiteProvider (Fix: Gawdl3y review) * Reorganise and add ignores * fix false error in enable command * Added isEmpty type to ArgumentInfo * Mark ArgumentInfo#isEmpty as optional * Change Collection Methods * Fix lint * Add nsfw reason to commandBlocked event docs * Fix formatting of CommandRegistry#registerDefaults description * Simplify validation checks in ArgumentUnionType * Update options in CommandoClient (Typings) (discordjs#152) * Remove selfbot mode * Apply fix for infinite arg with default (discordjs#161) Previously when having both infinite and default on 1 arg they would conflict. Namely say I have 2 args, one is a boolean and the other optional infinite roles (empty default). In this situation it is expected that `command on` just sets the boolean arg and keeps roles empty. The bot properly prompts if that is correct giving the user `cancel` or `finish` as options and then the error occurs. Previously when doing `finish` the command would just get canceled due to `user`, but clearly we don't want that since the arg has a default. * bump better-sqlite3 peer depend Windows build issues that were present between 4.0.1 and 4.1.1 were resolved in 4.1.2 with more Linux resolved by 4.1.4 so it is safe to just target the latest version again * Added double backticks to output where there previously were single backticks (discordjs#165) * Added double backticks to output where there previously were single backticks * Coding style: broke line that was too long into 2 lines * Reverted a bunch of double backticks troughout the codebase to single backticks, only leaving ones that could potentially benefit from being double in * Fix ESLint errors * Replace CommandMessage with CommandoMessage, extending Message * Fix ESLint errors * Fix ArgumentCollector * Fix resolveCommand for unknown command messages * readd message extension * Update require-all to 3.0.0 * Fix type returned by findCommands method * Fix better-sqlite3 (discordjs#172) Commando TypeScript will not currently compile, as there is not a `better-sqlite3` module. * Fix discordjs#178 * Fixed eval command not splitting base message correctly, and made dispatcher await array of message promises (discordjs#181) * Fixed eval command not splitting base message correctly, and made dispatcher await array of message promises * Added back missing args.script * Fix isEmpty for infinite argument (discordjs#184) * fix typings (discordjs#186) * fix typings commit 5942e8becc893beb8053e6ef9579aaebf0fa3e15 in discordjs/discord.js removed selfbot from code * changes requested by @dragonfire535 * Hidden Commands (discordjs#206) * Hidden Commands * Simplify conditions * Update base.js * Change wording * Typings * fix(Command): ignore args array if empty (discordjs#214) * Fix incorrect voiceStateUpdate typings interfering with discord.js master (discordjs#216) * Fix incorrect voiceStateUpdate typings interfering with discord.js master. * Update index.d.ts * Update index.d.ts
faizal101
added a commit
to faizal101/Commando
that referenced
this pull request
Nov 2, 2018
* Fix error not being overridden with async validators * Add union types to feature list * Change registerDefaultCommands to use eval instead of eval_, and improve docs * Improve more registry docs * Allow specifying specific types to register * Rearrange registration logic and improve docs * Remove useless commands parameter from CommandGroup constructor * Add dank testing of dank argument type functionality * Update typings * Remove unnecessary codeblock markdown * Specify that the guild's name is needed in help * message#member is a getter now. * Add BetterSQLite3 Provider * Fix: Emit distinct event for BetterSQLiteProvider * Resolve vague method naming * Resolves distinct event by using @fires to reference providerReady event * Bump development version * Make getGuildID static in Typings * Update Typings (discordjs#151) Added Client as an alias of CommandoClient Added util and version * Remove duplicate setProvider method (Fix: Gawdl3y review) * Rename BetterSQLite3Provider to SyncSQLiteProvider (Fix: Gawdl3y review) * Reorganise and add ignores * fix false error in enable command * Added isEmpty type to ArgumentInfo * Mark ArgumentInfo#isEmpty as optional * Change Collection Methods * Fix lint * Add nsfw reason to commandBlocked event docs * Fix formatting of CommandRegistry#registerDefaults description * Simplify validation checks in ArgumentUnionType * Update options in CommandoClient (Typings) (discordjs#152) * Remove selfbot mode * Apply fix for infinite arg with default (discordjs#161) Previously when having both infinite and default on 1 arg they would conflict. Namely say I have 2 args, one is a boolean and the other optional infinite roles (empty default). In this situation it is expected that `command on` just sets the boolean arg and keeps roles empty. The bot properly prompts if that is correct giving the user `cancel` or `finish` as options and then the error occurs. Previously when doing `finish` the command would just get canceled due to `user`, but clearly we don't want that since the arg has a default. * bump better-sqlite3 peer depend Windows build issues that were present between 4.0.1 and 4.1.1 were resolved in 4.1.2 with more Linux resolved by 4.1.4 so it is safe to just target the latest version again * Added double backticks to output where there previously were single backticks (discordjs#165) * Added double backticks to output where there previously were single backticks * Coding style: broke line that was too long into 2 lines * Reverted a bunch of double backticks troughout the codebase to single backticks, only leaving ones that could potentially benefit from being double in * Fix ESLint errors * Replace CommandMessage with CommandoMessage, extending Message * Fix ESLint errors * Fix ArgumentCollector * Fix resolveCommand for unknown command messages * readd message extension * Update require-all to 3.0.0 * Fix type returned by findCommands method * Fix better-sqlite3 (discordjs#172) Commando TypeScript will not currently compile, as there is not a `better-sqlite3` module. * Fix discordjs#178 * Fixed eval command not splitting base message correctly, and made dispatcher await array of message promises (discordjs#181) * Fixed eval command not splitting base message correctly, and made dispatcher await array of message promises * Added back missing args.script * Fix isEmpty for infinite argument (discordjs#184) * fix typings (discordjs#186) * fix typings commit 5942e8becc893beb8053e6ef9579aaebf0fa3e15 in discordjs/discord.js removed selfbot from code * changes requested by @dragonfire535 * Hidden Commands (discordjs#206) * Hidden Commands * Simplify conditions * Update base.js * Change wording * Typings * fix(Command): ignore args array if empty (discordjs#214) * Fix incorrect voiceStateUpdate typings interfering with discord.js master (discordjs#216) * Fix incorrect voiceStateUpdate typings interfering with discord.js master. * Update index.d.ts * Update index.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for hidden commands.
Fixes #204