This repository was archived by the owner on Oct 5, 2025. It is now read-only.
Update guide to v14 code#1146
Merged
almostSouji merged 59 commits intodiscordjs:mainfrom Jul 22, 2022
lolollllo:v14
Merged
Conversation
megatank58
reviewed
Jun 5, 2022
theblusniper
suggested changes
Jun 5, 2022
Member
|
Contributor
Author
oh okay. sry |
theblusniper
approved these changes
Jun 9, 2022
megatank58
reviewed
Jun 12, 2022
theblusniper
suggested changes
Jun 12, 2022
theblusniper
approved these changes
Jun 12, 2022
theblusniper
suggested changes
Jun 13, 2022
theblusniper
suggested changes
Jun 13, 2022
theblusniper
approved these changes
Jun 14, 2022
|
Any ETA on when this will be merged? |
Member
|
when v14 is released |
almeidx
reviewed
Jun 19, 2022
Member
almeidx
left a comment
almeidx
left a comment
There was a problem hiding this comment.
Can you change MessageSelectMenu -> SelectMenuBuilder
Jiralite
suggested changes
Jun 19, 2022
Member
Jiralite
left a comment
Jiralite
left a comment
There was a problem hiding this comment.
In guide/popular-topics/webhooks.md, the example to create a webhook needs updating.
theblusniper
approved these changes
Jun 19, 2022
theblusniper
left a comment
theblusniper
left a comment
There was a problem hiding this comment.
Review dismissed, already resolved
theblusniper
suggested changes
Jun 19, 2022
theblusniper
approved these changes
Jun 20, 2022
theblusniper
left a comment
theblusniper
left a comment
There was a problem hiding this comment.
Basically just replace interaction.isChatInputCommand() with interaction.type === InteractionType.ApplicationCommand
Contributor
Make sure to make the unequal comparison correct tho. |
imranbarbhuiya
suggested changes
Jul 21, 2022
almeidx
suggested changes
Jul 21, 2022
Co-authored-by: Almeida <almeidx@pm.me>
Contributor
Author
megatank58
reviewed
Jul 22, 2022
Co-authored-by: megatank58 <tanumegatank@gmail.com>
Co-authored-by: megatank58 <tanumegatank@gmail.com>
Co-authored-by: megatank58 <tanumegatank@gmail.com>
Co-authored-by: megatank58 <tanumegatank@gmail.com>
Contributor
Author
|
Resolved |
Closed
Closed
Contributor
Author
|
Anything else? |
Jiralite
reviewed
Jul 22, 2022
|
Should I wait for this merge to be complete before following this guide, just to avoid problems? It seems close! |
Contributor
Author
|
Anything else? |
Member
|
Please make atomic PRs for follow-ups or other change requests |
almostSouji
pushed a commit
that referenced
this pull request
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged: